add new s3 ASF provider #6829
add new s3 ASF provider #6829
Conversation
There was a problem hiding this comment.
LGTM! 🚀 Just a small hint that the params for the decorator aren't even necessary.
Considering the immense size of S3, it is definitely the best approach to integrate with the mainline as often as possible and just enabling the feature flag in a long-living PR to get continuous test feedback. 🥳
| @@ -258,7 +258,7 @@ def route53resolver(): | |||
| ) | |||
|
|
|||
|
|
|||
| @aws_provider() | |||
| @aws_provider(api="s3", name="default") | |||
There was a problem hiding this comment.
The params for the decorator here actually aren't necessary, since the default for api is the function's name (s3) and the default for name is default.
There was a problem hiding this comment.
Thanks! It makes a lot of sense. I will update once the tests run, there should not be any issue but I'd rather be certain 😅
|
Oops, forgot to fix your comment @alexrashed, I had committed the changes and waited for the tests to succeed before pushing, but with the coverage failure, I forgot. I will correct this in the next PR that we need to do for s3. Sorry again 😕 |
This PR is part of #6827 and is the basis for migrating s3 to ASF.
It creates the new s3 ASF provider marked as
asfas well as the scaffoldeds3API. It sets the current s3 provider asdefault.This should make no changes to the current implementation, and can only be used with
PROVIDER_OVERRIDE_S3=asf(not stable at all for now!)This is @steffyP works and I'm just making the PR 🎉