pin boto3 and botocore versions #7088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whummer
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Very interesting, great catch. LGTM 👍 as a quick fix for now.
Curious to see how the "endpoints 2.0" initiative (which has been recently mentioned in a couple of AWS SDK client repos) will pan out. Currently this still seems to be a more flexible way to determine target endpoints based on rule sets, but who knows - maybe this could be a first step towards boto/boto3#2746 (comment) . 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boto/botocore recently changed the endpoint detection: boto/botocore@357d5a8
These changes (which are contained in
boto3==1.25.0/botocore==1.2.8) break some of the internal APIs we are using for testing and for our forwarding API (because the endpoint parameter became mandatory), and have impact on the routing (due to changes with the endpoints).This PR provides a quick-fix by pinning to the previous versions.
The root cause / adjustment to the new versions will be addressed #7086.