-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Lambda permissions #7336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lambda permissions #7336
Conversation
a8dc4e3
to
8b71473
Compare
8b71473
to
b6caf51
Compare
1022e64
to
233db5d
Compare
…igs" This reverts commit 2e97776.
233db5d
to
c93cb22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome 👍
just some smaller questions so far
To be fixed in follow-up PR and tested for lambda in general.
Add snapshot tests for version and alias to capture sid scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit, otherwise LGTM though! 🥳
Feel free to merge after addressing it!
Good attention to detail and well documented 👍
Looking forward to the follow-up 😁
great, thanks for the suggestions @dominikschubert |
Tests and fixes several TODOs related to Lambda permissions and ARN, qualifier handling, especially focusing on API validation and exception handling.
All changes apply to the new lambda provider enabled through
PROVIDER_OVERRIDE_LAMBDA=asf
TODO: is this unique just in the policy or across all policies in region/account/function (?)
inprovider.py
)revision_id
forremove_permission
revision_id
foradd_permission
localstack.services.awslambda.lambda_api.add_permission_policy_statement
_validate_qualifier_expression
and_resolve_fn_qualifier
could be re-used in lambda (e.g., see TODOs increate_function_url_config
)localstack.services.awslambda.api_utils.build_statement
(hard to testTODO: add test for event_source_token (alexa smart home) and auth_type
)Follow-Up (out of scope in this PR)
VersionFunctionConfiguration
).