Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add lambda permission behavior test #7446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2023
Merged

Add lambda permission behavior test #7446

merged 2 commits into from
Jan 10, 2023

Conversation

joe4dev
Copy link
Member

@joe4dev joe4dev commented Jan 6, 2023

Follow up from lambda permission PR #7336

Having an AWS-validated test case ready is useful for implementing actual permission policy logic.

@joe4dev joe4dev requested a review from dfangl as a code owner January 6, 2023 15:15
@joe4dev joe4dev temporarily deployed to localstack-ext-tests January 6, 2023 15:15 — with GitHub Actions Inactive
@joe4dev joe4dev removed the request for review from dfangl January 6, 2023 15:15
@coveralls
Copy link

Coverage Status

Coverage: 84.912% (+0.02%) from 84.891% when pulling 9914934 on test-lambda-permission-behavior into d3f51d5 on master.

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 32m 44s ⏱️ + 7m 20s
1 610 tests +1  1 318 ✔️ +1  292 💤 ±0  0 ❌ ±0 
2 264 runs  +3  1 688 ✔️ +1  576 💤 +2  0 ❌ ±0 

Results for commit 9914934. ± Comparison against base commit d3f51d5.

dominikschubert
dominikschubert approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Definitely useful to have, even if we'll still have to implement the IAM enforcement for this

@joe4dev joe4dev temporarily deployed to localstack-ext-tests January 10, 2023 08:14 — with GitHub Actions Inactive
@joe4dev joe4dev merged commit cba9210 into master Jan 10, 2023
@joe4dev joe4dev deleted the test-lambda-permission-behavior branch January 10, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joe4dev @coveralls @dominikschubert