Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix naming from Lambda revisions PR #7551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2023
Merged

Fix naming from Lambda revisions PR #7551

merged 1 commit into from
Jan 25, 2023

Conversation

joe4dev
Copy link
Member

@joe4dev joe4dev commented Jan 25, 2023 •
edited
Loading

Follow up of #7482
Fixes Daniel's naming comment.

@joe4dev
Rename resolved alias and version
a49d9d6 
Resolves misleading naming especially for latest_version (pretends it is $LATEST) but actually refers to the resolved qualifier.
Fixes Daniel's comment: #7482 (comment)
@joe4dev joe4dev requested review from dfangl and thrau as code owners January 25, 2023 11:23
@joe4dev joe4dev temporarily deployed to localstack-ext-tests January 25, 2023 11:23 — with GitHub Actions Inactive
@joe4dev joe4dev force-pushed the lambda-public-layers-v2 branch from b11f2e2 to a49d9d6 Compare January 25, 2023 11:37
@joe4dev joe4dev temporarily deployed to localstack-ext-tests January 25, 2023 11:38 — with GitHub Actions Inactive
@joe4dev joe4dev changed the title Add external layer fetching for new lambda provider Fix naming from Lambda revisions PR Jan 25, 2023
@github-actions
Copy link

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 26m 19s ⏱️ + 1m 42s
1 659 tests ±0  1 332 ✔️ ±0  327 💤 ±0  0 ❌ ±0 
2 359 runs  ±0  1 704 ✔️ ±0  655 💤 ±0  0 ❌ ±0 

Results for commit a49d9d6. ± Comparison against base commit 8f77fa8.

dfangl
dfangl approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for opening a PR just to fix the variable naming ;)

@joe4dev joe4dev merged commit e8a7f54 into master Jan 25, 2023
@joe4dev joe4dev deleted the lambda-public-layers-v2 branch January 25, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

@thrau thrau Awaiting requested review from thrau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joe4dev @dfangl