add S3 CORS test with referer header and regenerate CORS snaphots #8776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 3, 2023
876e72e to
778b113
Compare
778b113 to
4c7a926
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a support case, added a test case validating that AWS does not return CORS headers if no
Originheader is present, even if therefererone is there.I took the opportunity to regenerate the snapshots, knowing there was now an issue regarding ACL, so I've added a new fixture to allow ACL on bucket. Something changed on AWS side, so I've fixed a small field for an Exception returned.
Also refactored a bit the code to use the fix made in #6865, allowing us to add fields to the exception at instantiation as parameters and not by attaching them directly to the exception object like before.
\cc @steffyP for the snapshot regeneration/fixture allowing AWS tests