Thanks to visit codestin.com
Credit goes to github.com

Skip to content

make new s3 v3 provider default #8785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 6, 2023
Merged

make new s3 v3 provider default #8785

merged 4 commits into from
Nov 6, 2023

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Jul 31, 2023 •
edited
Loading

Motivation

This PR will make the new s3 v3 provider default for the new 3.0 release.

Changes

Make the new provider default, create a new legacy_v2 provider for S3 for us to advertise instead of v2 or asf which don't communicate well the fact that it's the previous implementation.

Remove checks for NATIVE_PROVIDER as it's now default, and invert the checks.

Add a warning if people are still using v2.

Updated the CI job to test legacy v2, we can keep until the release of 3.1 to ensure stability and visibility into moto changes.

Note: sorry for the changes once again in the tests conditions, I missed this change in the removal of the legacy code.

Contained PRs (30):

Incoming PRs:

  • /

@bentsku bentsku added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases aws:s3 Amazon Simple Storage Service labels Jul 31, 2023
@bentsku bentsku self-assigned this Jul 31, 2023
@bentsku bentsku changed the base branch from master to s3-native-cors August 4, 2023 23:21
@bentsku bentsku changed the base branch from s3-native-cors to master August 4, 2023 23:21
@bentsku bentsku force-pushed the new-s3-native-provider branch 7 times, most recently from b6c5246 to 2c9e482 Compare August 10, 2023 14:52
@github-actions
Copy link

github-actions bot commented Aug 10, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files  ±0         2 suites  ±0   1h 11m 46s ⏱️ +57s
2 325 tests ±0  1 790 ✔️ +43  535 💤  - 43  0 ❌ ±0 
2 326 runs  ±0  1 790 ✔️ +43  536 💤  - 43  0 ❌ ±0 

Results for commit b6a5649. ± Comparison against base commit 99278b3.

♻️ This comment has been updated with latest results.

@bentsku bentsku force-pushed the new-s3-native-provider branch 2 times, most recently from 9a3988c to 596f6df Compare August 10, 2023 22:15
@bentsku
Copy link
Contributor Author

bentsku commented Aug 12, 2023 •
edited
Loading

Update: around 60 tests are still failing on 23/09/10, mostly related to pre-signed URLs

@bentsku bentsku force-pushed the new-s3-native-provider branch 5 times, most recently from a265619 to d758d94 Compare August 15, 2023 22:36
@bentsku
Copy link
Contributor Author

bentsku commented Aug 16, 2023 •
edited
Loading

Update: only 1 or 2 tests are failing:

  • test_delete_has_empty_content_length_header
  • test_apigateway_rust_lambda

edit: this was due to some wrong logic in the storage layer, this should now be fixed 🎉

@bentsku bentsku force-pushed the new-s3-native-provider branch 2 times, most recently from 5ca1c2d to d6c9525 Compare August 16, 2023 16:38
@coveralls
Copy link

coveralls commented Aug 16, 2023 •
edited
Loading

Coverage Status

coverage: 83.796% (-0.03%) from 83.827%
when pulling b6a5649 on new-s3-native-provider
into 99278b3 on release/v3.0.

@bentsku bentsku force-pushed the new-s3-native-provider branch 5 times, most recently from 8bde1ac to 3545e7e Compare August 29, 2023 13:04
@alexrashed alexrashed force-pushed the release/v3.0 branch 2 times, most recently from 19c8422 to 6ff5c4c Compare November 2, 2023 09:24
@bentsku bentsku force-pushed the new-s3-native-provider branch from ef5eb95 to 3fcbb2a Compare November 2, 2023 16:14
@bentsku bentsku force-pushed the new-s3-native-provider branch from 7defab6 to 8d09b49 Compare November 3, 2023 09:47
@bentsku bentsku force-pushed the new-s3-native-provider branch 2 times, most recently from 18da430 to a966604 Compare November 4, 2023 13:45
@bentsku bentsku force-pushed the new-s3-native-provider branch from a966604 to b6a5649 Compare November 6, 2023 09:57
@bentsku bentsku marked this pull request as ready for review November 6, 2023 10:00
alexrashed
alexrashed approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Really great to see the native provider becoming the default! 🚀 🧹

@bentsku bentsku merged commit 1777130 into release/v3.0 Nov 6, 2023
@bentsku bentsku deleted the new-s3-native-provider branch November 6, 2023 10:56
@alexrashed alexrashed mentioned this pull request Nov 6, 2023
Merged
20 tasks
localstack-bot pushed a commit that referenced this pull request Nov 7, 2023
@bentsku
make new s3 v3 provider default (#8785)
2903f6e
alexrashed pushed a commit that referenced this pull request Nov 7, 2023
@bentsku @alexrashed
make new s3 v3 provider default (#8785)
b22835b
alexrashed pushed a commit that referenced this pull request Nov 7, 2023
@bentsku @alexrashed
make new s3 v3 provider default (#8785)
515eae9
localstack-bot pushed a commit that referenced this pull request Nov 9, 2023
@bentsku
make new s3 v3 provider default (#8785)
c4c999b
alexrashed pushed a commit that referenced this pull request Nov 9, 2023
@bentsku @alexrashed
make new s3 v3 provider default (#8785)
5980237
alexrashed pushed a commit that referenced this pull request Nov 9, 2023
@bentsku @alexrashed
make new s3 v3 provider default (#8785)
8ea4b47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@macnev2013 macnev2013 Awaiting requested review from macnev2013

@thrau thrau Awaiting requested review from thrau

@dfangl dfangl Awaiting requested review from dfangl

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

Assignees

@bentsku bentsku

Labels
aws:s3 Amazon Simple Storage Service semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bentsku @coveralls @alexrashed