Thanks to visit codestin.com
Credit goes to github.com

Skip to content

implement S3 native Lifecycle + mocked Bucket APIs #8863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2023
Merged

implement S3 native Lifecycle + mocked Bucket APIs #8863

merged 1 commit into from
Aug 14, 2023

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Aug 8, 2023

Motivation

This PR implements/migrate S3 Lifecycle to the new S3 native provider, as well as the following mocked APIs:

  • AnalyticsConfiguration
  • IntelligentTieringConfiguration
  • InventoryConfiguration

Changes

This migrates the code to be compatible with both provider, and implements it in the new provider. As the changes were pretty minimal, I've also migrated simple only mocked APIs as well.

@bentsku bentsku added aws:s3 Amazon Simple Storage Service semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Aug 8, 2023
@bentsku bentsku self-assigned this Aug 8, 2023
@bentsku bentsku mentioned this pull request Aug 8, 2023
Merged
@bentsku bentsku force-pushed the s3-native-lifecycle branch from 7f2d20f to 01e4f7a Compare August 8, 2023 22:44
@bentsku bentsku force-pushed the s3-native-lifecycle branch from 01e4f7a to 33258ba Compare August 10, 2023 10:30
@coveralls
Copy link

coveralls commented Aug 10, 2023 •
edited
Loading

Coverage Status

coverage: 81.383% (-0.1%) from 81.504% when pulling ae49c00 on s3-native-lifecycle into 0b78a1f on s3-native-cors.

@bentsku bentsku marked this pull request as ready for review August 10, 2023 11:58
@bentsku bentsku requested a review from macnev2013 as a code owner August 10, 2023 11:58
@bentsku bentsku requested a review from thrau as a code owner August 10, 2023 22:21
@bentsku bentsku force-pushed the s3-native-lifecycle branch from 33258ba to ce03168 Compare August 10, 2023 22:21
@bentsku bentsku force-pushed the s3-native-lifecycle branch from ce03168 to b9f8ef0 Compare August 10, 2023 22:26
@bentsku bentsku force-pushed the s3-native-lifecycle branch from b9f8ef0 to 5024e6d Compare August 13, 2023 00:49
thrau
thrau approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bentsku bentsku force-pushed the s3-native-lifecycle branch from 5024e6d to ae49c00 Compare August 14, 2023 20:01
Base automatically changed from s3-native-cors to master August 14, 2023 21:22
@bentsku bentsku force-pushed the s3-native-lifecycle branch from ae49c00 to 65ec6b0 Compare August 14, 2023 22:25
@github-actions
Copy link

LocalStack Community integration with Pro

       2 files         2 suites   1h 28m 17s ⏱️
2 060 tests 1 656 ✔️ 404 💤 0 ❌
2 061 runs  1 656 ✔️ 405 💤 0 ❌

Results for commit 65ec6b0.

@bentsku bentsku merged commit 0095774 into master Aug 14, 2023
@bentsku bentsku deleted the s3-native-lifecycle branch August 14, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrau thrau thrau approved these changes

@macnev2013 macnev2013 Awaiting requested review from macnev2013

Assignees

@bentsku bentsku

Labels
aws:s3 Amazon Simple Storage Service semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bentsku @coveralls @thrau