Thanks to visit codestin.com
Credit goes to github.com

Skip to content

implement S3 native notifications #8802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2023
Merged

implement S3 native notifications #8802

merged 1 commit into from
Aug 10, 2023

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Aug 2, 2023

This PR implement notifications for the new native S3 provider.

Only 2 types of notifications are missing, concerning ACL and Tagging, because those operations are not yet implemented in the new provider but this will come. The most important was to make it compatible with the new provider.

@bentsku bentsku added aws:s3 Amazon Simple Storage Service semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Aug 2, 2023
@bentsku bentsku self-assigned this Aug 2, 2023
@bentsku bentsku mentioned this pull request Aug 2, 2023
Merged
@bentsku bentsku force-pushed the s3-native-encryption branch from 81449f1 to c093df0 Compare August 2, 2023 13:12
@bentsku bentsku force-pushed the s3-native-notifications branch from bb279e7 to 76358fe Compare August 2, 2023 13:13
@coveralls
Copy link

coveralls commented Aug 2, 2023 •
edited
Loading

Coverage Status

coverage: 81.434% (-0.08%) from 81.518% when pulling 38368a7 on s3-native-notifications into 0283e23 on s3-native-encryption.

@bentsku bentsku force-pushed the s3-native-encryption branch from c093df0 to 2e33061 Compare August 7, 2023 14:52
@bentsku bentsku force-pushed the s3-native-notifications branch 2 times, most recently from c2e20c6 to 54f3eb4 Compare August 7, 2023 15:26
@bentsku bentsku force-pushed the s3-native-encryption branch from 7da064e to 0283e23 Compare August 8, 2023 02:41
@bentsku bentsku force-pushed the s3-native-notifications branch from 54f3eb4 to 38368a7 Compare August 8, 2023 02:47
@bentsku bentsku force-pushed the s3-native-encryption branch 3 times, most recently from 86ed54e to d526d3c Compare August 8, 2023 22:01
@bentsku bentsku force-pushed the s3-native-notifications branch from 38368a7 to f4da220 Compare August 8, 2023 22:01
@bentsku bentsku force-pushed the s3-native-encryption branch from d526d3c to da072db Compare August 9, 2023 20:04
@bentsku bentsku force-pushed the s3-native-notifications branch 2 times, most recently from 4be055c to c3e8ef0 Compare August 9, 2023 20:11
@bentsku bentsku marked this pull request as ready for review August 10, 2023 10:23
@bentsku bentsku requested a review from macnev2013 as a code owner August 10, 2023 10:23
macnev2013
macnev2013 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@macnev2013 macnev2013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Base automatically changed from s3-native-encryption to master August 10, 2023 21:15
@bentsku bentsku requested a review from thrau as a code owner August 10, 2023 21:15
@bentsku bentsku force-pushed the s3-native-notifications branch from c3e8ef0 to 91d8151 Compare August 10, 2023 21:17
@bentsku bentsku merged commit 8668d18 into master Aug 10, 2023
@bentsku bentsku deleted the s3-native-notifications branch August 10, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macnev2013 macnev2013 macnev2013 approved these changes

@thrau thrau Awaiting requested review from thrau

Assignees

@bentsku bentsku

Labels
aws:s3 Amazon Simple Storage Service semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bentsku @coveralls @macnev2013