implement S3 native bucket versioning #8799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 1, 2023
35742aa to
b874cea
Compare
59ee74f to
6abdab2
Compare
26a399d to
733f722
Compare
6abdab2 to
08162e0
Compare
9686f44 to
d8dbb04
Compare
08162e0 to
1fd8bd6
Compare
d8dbb04 to
6df3c6d
Compare
1fd8bd6 to
e77d9bf
Compare
e77d9bf to
61947dd
Compare
bentsku
commented
Aug 8, 2023
| @@ -5982,6 +5982,7 @@ def test_post_request_missing_signature( | |||
| ) | |||
|
|
|||
| # AWS seems to detected what kind of signature is missing from the policy fields | |||
| print(response.content) | |||
There was a problem hiding this comment.
will remove in the next PR if possible, as I wouldn't want to rebase everything. It could be merged right after!
61947dd to
0888220
Compare
thrau
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
LGTM! nice that it's so easy :D i'll let @alexrashed sign off on the serializer change
alexrashed
approved these changes
Aug 9, 2023
0888220 to
e86455d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Bucket Versioning in the new native S3 provider. This in turn allowed me to properly tests what I had already written but couldn't test because I couldn't actually enable the versioning, and fix what was wrong.
This PR also contains a new feature in the serializer: we couldn't add headers to exceptions, when S3 actually does that. I'm not sure this is common to all XML protocol based services, so I contained it only in S3 for now. I tried to keep the same existing logic as much as I could, but applied to exceptions.