Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add S3 native bucket encryption and AWS KMS managed key #8800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 10, 2023
Merged

add S3 native bucket encryption and AWS KMS managed key #8800

merged 2 commits into from
Aug 10, 2023

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Aug 2, 2023 •
edited
Loading

This PR implements Bucket Encryption, and sets the new default to AES256 like AWS does since April 2023.

It also implements a feature we've been missing, when not specifying a KMS KeyId when using aws:kms encryption, we're now creating and keeping the reference to the AWS managed key. We're however missing an internal way to specify that the key is "AWS managed", and not customer managed.

@bentsku bentsku added aws:s3 Amazon Simple Storage Service semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Aug 2, 2023
@bentsku bentsku self-assigned this Aug 2, 2023
@bentsku bentsku force-pushed the s3-native-encryption branch from e35c322 to 504c433 Compare August 2, 2023 01:33
@bentsku bentsku mentioned this pull request Aug 2, 2023
Merged
@bentsku bentsku force-pushed the s3-native-encryption branch from 81449f1 to c093df0 Compare August 2, 2023 13:12
@coveralls
Copy link

coveralls commented Aug 2, 2023 •
edited
Loading

Coverage Status

coverage: 81.742% (-0.07%) from 81.81% when pulling 69dd982 on s3-native-encryption into 78f635a on master.

@bentsku bentsku force-pushed the s3-native-versioning branch 3 times, most recently from 6abdab2 to 08162e0 Compare August 7, 2023 14:51
@bentsku bentsku force-pushed the s3-native-encryption branch from c093df0 to 2e33061 Compare August 7, 2023 14:52
@bentsku bentsku force-pushed the s3-native-versioning branch from 08162e0 to 1fd8bd6 Compare August 8, 2023 02:35
@bentsku bentsku force-pushed the s3-native-encryption branch from 7da064e to 0283e23 Compare August 8, 2023 02:41
@bentsku bentsku force-pushed the s3-native-versioning branch from 1fd8bd6 to e77d9bf Compare August 8, 2023 14:04
@bentsku bentsku force-pushed the s3-native-encryption branch from 0283e23 to af89c04 Compare August 8, 2023 14:36
@bentsku bentsku force-pushed the s3-native-versioning branch from e77d9bf to 61947dd Compare August 8, 2023 15:35
@bentsku bentsku force-pushed the s3-native-encryption branch from af89c04 to 86ed54e Compare August 8, 2023 15:38
@bentsku bentsku force-pushed the s3-native-versioning branch from 61947dd to 0888220 Compare August 8, 2023 22:01
@bentsku bentsku force-pushed the s3-native-encryption branch from 86ed54e to d526d3c Compare August 8, 2023 22:01
@bentsku bentsku marked this pull request as ready for review August 8, 2023 22:02
@bentsku bentsku force-pushed the s3-native-versioning branch from 0888220 to e86455d Compare August 9, 2023 13:10
@bentsku bentsku requested a review from alexrashed as a code owner August 9, 2023 13:10
Base automatically changed from s3-native-versioning to master August 9, 2023 14:35
@bentsku bentsku removed the request for review from alexrashed August 9, 2023 17:59
@bentsku bentsku force-pushed the s3-native-encryption branch from d526d3c to da072db Compare August 9, 2023 20:04
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 22m 54s ⏱️
2 049 tests 1 655 ✔️ 394 💤 0 ❌
2 050 runs  1 655 ✔️ 395 💤 0 ❌

Results for commit 69dd982.

macnev2013
macnev2013 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@macnev2013 macnev2013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR. 🚀 LGTM

Just a minor question.

@bentsku bentsku merged commit 5b15287 into master Aug 10, 2023
@bentsku bentsku changed the title add S3 native bucket encryption and AWS key managed key add S3 native bucket encryption and AWS KMS managed key Aug 10, 2023
@bentsku bentsku deleted the s3-native-encryption branch August 10, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macnev2013 macnev2013 macnev2013 approved these changes

@thrau thrau Awaiting requested review from thrau

Assignees

@bentsku bentsku

Labels
aws:s3 Amazon Simple Storage Service semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bentsku @coveralls @macnev2013