Thanks to visit codestin.com
Credit goes to github.com

Skip to content

implement S3 native tagging #8811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2023
Merged

implement S3 native tagging #8811

merged 1 commit into from
Aug 12, 2023

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Aug 3, 2023

This PR implements all tagging related operations and usage:

Tagging with:

  • PutObject
  • CopyObject (and TaggingDirective)
  • PutObjectTagging
  • DeleteObjectTagging
  • GetObjectTagging
  • PutBucketTagging
  • DeleteBucketTagging
  • GetBucketTagging

As well as S3 notifications support for Put/Delete object tagging.

@bentsku bentsku self-assigned this Aug 3, 2023
@bentsku bentsku added aws:s3 Amazon Simple Storage Service semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Aug 3, 2023
@bentsku bentsku mentioned this pull request Aug 3, 2023
Merged
@coveralls
Copy link

coveralls commented Aug 3, 2023 •
edited
Loading

Coverage Status

coverage: 81.488% (-0.1%) from 81.601% when pulling 897b718 on s3-native-tagging into 8668d18 on master.

@bentsku bentsku force-pushed the s3-native-notifications branch from b375bc4 to c52c498 Compare August 7, 2023 14:56
@bentsku bentsku force-pushed the s3-native-tagging branch from 59f24eb to dd31f9c Compare August 7, 2023 14:56
@bentsku bentsku force-pushed the s3-native-notifications branch from c2e20c6 to 54f3eb4 Compare August 7, 2023 15:26
@bentsku bentsku force-pushed the s3-native-tagging branch from dd31f9c to 659e02d Compare August 7, 2023 15:26
@bentsku bentsku force-pushed the s3-native-notifications branch 2 times, most recently from 38368a7 to f4da220 Compare August 8, 2023 22:01
@bentsku bentsku force-pushed the s3-native-tagging branch from 659e02d to f0f245f Compare August 8, 2023 22:01
@bentsku bentsku force-pushed the s3-native-notifications branch 2 times, most recently from 4be055c to c3e8ef0 Compare August 9, 2023 20:11
@bentsku bentsku force-pushed the s3-native-tagging branch from f0f245f to 6d255bd Compare August 10, 2023 10:27
@bentsku bentsku marked this pull request as ready for review August 10, 2023 11:58
bentsku
bentsku commented Aug 10, 2023
View reviewed changes
tests/aws/s3/test_s3_api.snapshot.json Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the snapshots were generated before the tests directory change. As they're skipped currently when the new provider is not set, it did not come up. This is fixed in a subsequent PR: #8884

thrau
thrau approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🏷️ 🚀

localstack/services/s3/v3/provider.py
Comment on lines +2122 to +2124
# There a weird AWS validated bug in S3: the returned key contains the bucket name as well
# follow AWS on this one
e.Key = f"{bucket}/{key}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s3 intensifies

macnev2013
macnev2013 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@macnev2013 macnev2013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@bentsku bentsku force-pushed the s3-native-notifications branch from c3e8ef0 to 91d8151 Compare August 10, 2023 21:17
Base automatically changed from s3-native-notifications to master August 10, 2023 22:12
@bentsku bentsku force-pushed the s3-native-tagging branch from 6d255bd to 897b718 Compare August 10, 2023 22:16
@github-actions
Copy link

LocalStack Community integration with Pro

       2 files         2 suites   1h 28m 3s ⏱️
2 058 tests 1 656 ✔️ 402 💤 0 ❌
2 059 runs  1 656 ✔️ 403 💤 0 ❌

Results for commit 897b718.

@bentsku bentsku merged commit 2256615 into master Aug 12, 2023
@bentsku bentsku deleted the s3-native-tagging branch August 12, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrau thrau thrau approved these changes

@macnev2013 macnev2013 macnev2013 approved these changes

Assignees

@bentsku bentsku

Labels
aws:s3 Amazon Simple Storage Service semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bentsku @coveralls @thrau @macnev2013