Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[SFN] Support for UpdateStateMachine #8852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented Aug 8, 2023

Motivation

Adds missing support for StepFunction's UpdateStateMachine api calls, contributing to the greenification of #8779, which sets StepFunction v2 as default provider.

Changes

In v2 provider:

  • implementation of update_state_machine endpoint
  • cleanups regarding the validation of definitions that now occurs in 2 places (creation and update)
  • other minor changes including deepcopying state machines on execution to prevent future updated to change their parameters (as instructed by AWS)

In state machine:

  • added required logic for revision injection
  • moved description output here from the provider to fit the design pattern of executions

Testing

Added base snapshot scenarios about update_state_machine:

  • test_create_update_state_machine_base_definition
  • test_create_update_state_machine_base_role_arn
  • test_create_update_state_machine_base_definition_and_role
  • test_create_update_state_machine_base_update_none
  • test_create_update_state_machine_same_parameters

@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Aug 8, 2023
@MEPalma MEPalma added this to the 2.3 milestone Aug 8, 2023
@MEPalma MEPalma self-assigned this Aug 8, 2023
@coveralls
Copy link

coveralls commented Aug 8, 2023

Coverage Status

coverage: 81.819% (+0.009%) from 81.81% when pulling c022615 on MEP-sfn-update_state_machine into 78f635a on master.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 25m 49s ⏱️
2 057 tests 1 656 ✔️ 401 💤 0
2 058 runs  1 656 ✔️ 402 💤 0

Results for commit c639972.

♻️ This comment has been updated with latest results.

Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MEPalma MEPalma merged commit eb05add into master Aug 16, 2023
@MEPalma MEPalma deleted the MEP-sfn-update_state_machine branch August 16, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants