implement S3 native Website #8864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f2d20f to
01e4f7a
Compare
81ad9d0 to
6305500
Compare
01e4f7a to
33258ba
Compare
6305500 to
ad12ee0
Compare
ad12ee0 to
649dd3d
Compare
33258ba to
ce03168
Compare
649dd3d to
bf92734
Compare
thrau
approved these changes
Aug 11, 2023
b9f8ef0 to
5024e6d
Compare
bf92734 to
c034bae
Compare
5024e6d to
ae49c00
Compare
c034bae to
144e2c5
Compare
ae49c00 to
65ec6b0
Compare
144e2c5 to
a787d67
Compare
a787d67 to
182905f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR migrate the current S3 Website router to be compatible with both providers, as well as implementing the BucketWebsite API.
Changes
The current S3 website was very tightly coupled with the moto backend, making it impossible to use with the new provider. We discussed it quickly with @alexrashed, and the internal boto client makes much more sense to use here as it totally abstracts away any difference there might be in the providers. Currently the implementation is the same as the previous one.
I've also changed some operations to be multi-account aware, so that they're able to access any buckets in any account when using the boto client. \cc @viren-nadkarni