implement S3 native object lock #8884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad12ee0 to
649dd3d
Compare
1265be6 to
66f9f51
Compare
649dd3d to
bf92734
Compare
d97e8f8 to
caecae3
Compare
bf92734 to
c034bae
Compare
thrau
approved these changes
Aug 14, 2023
localstack/services/s3/v3/models.py
Outdated
| self.is_current = True | ||
|
|
||
| @staticmethod | ||
| def is_locked(*_, **__) -> bool: |
There was a problem hiding this comment.
Suggested change
| def is_locked(*_, **__) -> bool: | |
| def is_locked(*args, **kwargs) -> bool: |
i know the IDE complains, but this is more readable :-)
if you "just can't" the warnings, you can also:
def is_locked(*_args, **_kwargs) -> bool:a787d67 to
182905f
Compare
caecae3 to
9628b50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implement the ObjectLock functionality in the new native S3 provider. This was partially implemented in our provider in order to fix Moto.
https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-lock-overview.html
https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-lock-managing.html
https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-lock.html
Changes
This PR adds the necessary API operations as well as a good amount of snapshot tests.
GetObjectLockConfigurationPutObjectLockConfigurationGetObjectLegalHoldPutObjectLegalHoldGetObjectRetentionPutObjectRetention