Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor localstack container config hooks #8890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

refactor localstack container config hooks #8890

wants to merge 2 commits into from

Conversation

thrau
Copy link
Member

@thrau thrau commented Aug 10, 2023

Motivation

The LocalstackContainer abstraction was introduced before ContainerConfiguration existed. We recently started unifying this in #8772 and are continuing to clean up container configuration procedure for @simonrw's work on creating bootstrap tests and cleaner abstractions.

Changes

  • Remove the remnants of exposing ContainerConfiguration attributes directly through LocalstackContainer
  • Make sure all configurator hooks operate on container.config rather than container

@thrau thrau requested a review from simonrw August 10, 2023 21:07
@thrau thrau added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Aug 10, 2023
@coveralls
Copy link

coveralls commented Aug 10, 2023 •
edited
Loading

Coverage Status

coverage: 81.554% (+0.007%) from 81.547% when pulling 8657488 on container-configurators into a7e97ea on master.

@github-actions
Copy link

github-actions bot commented Aug 10, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files         2 suites   1h 32m 46s ⏱️
2 060 tests 1 656 ✔️ 404 💤 0 ❌
2 061 runs  1 656 ✔️ 405 💤 0 ❌

Results for commit 8657488.

♻️ This comment has been updated with latest results.

@thrau thrau force-pushed the container-configurators branch from 872c4f5 to 8657488 Compare August 14, 2023 15:59
@thrau thrau mentioned this pull request Aug 30, 2023
Merged
@thrau thrau closed this Sep 13, 2023
@thrau thrau deleted the container-configurators branch September 13, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonrw simonrw Awaiting requested review from simonrw

Assignees
No one assigned
Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thrau @coveralls