implement S3 native ACL #8902
Merged
implement S3 native ACL #8902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
241be74 to
db3f515
Compare
db3f515 to
a3af01c
Compare
|
i'll let @macnev2013 review this one :-) |
macnev2013
approved these changes
Aug 21, 2023
| grantee = Grantee( | ||
| Type=GranteeType.CanonicalUser, | ||
| ID=grantee_id, | ||
| DisplayName="webfile", # TODO: only in certain regions |
There was a problem hiding this comment.
TODO: only in certain regions
Maybe in next iteration we can write a test case a snapshot validated parameterized test case. Which tests this specific scenario for all the regions.
There was a problem hiding this comment.
Yes, we should have a list of those regions in the S3 documentation, this would be great for parity! Right now we have the same behaviour as moto, but would be great to expand on it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implement S3 Bucket and Object ACL, even if not enforced, in the new S3 provider.
Changes
This combines Moto ACL implementation with the fixes we have in moto-ext. For this we are not going the extra miles, keeping the same functionality as we had. As we do not enforce ACL at the moment, this is fine. AWS does not encourage the use of ACL now.
Also added some tests for
GetObjectACL/PutObjectACLwhich were missing.This PR implements:
PutBucketACLGetObjectACLPutObjectACLGetObjectACLPutObjectCreateMultipartUploadCopyObject