replace CircleCI job for S3 stream to v3 and remove stream provider #9043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
719df73 to
05de505
Compare
alexrashed
approved these changes
Sep 19, 2023
😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now that the S3 v3 provider is ready, I'd like to replace the CircleCI job for the S3 stream provider to the new native.
We also should remove the stream provider (it didn't work with persistence anyway, so no backward compatibility issue), we can make
PROVIDER_OVERRIDE_S3=streamload the new provider as well.Changes
Replacing the job and make it necessary to pass for the build to be fully green (it wasn't a necessary step for pushing before, to avoid flakiness for such a small subset).
Removing the
streamprovider patching and make it point to thev3provider.Also a small fix regarding a refactoring in the stream provider for the
AwsChunkedDecoderwhich hadn't been ported to the v3 provider (and no tests to show it 😅)