Add S3 deprecation warnings #9204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentsku
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Awesome, thank you so much for doing this! I think you resumed things perfectly, I don't know when we will start deprecating v2, maybe around 3.1/3.2? I don't think we will deprecate it straight away, it's exactly as you wrote it. Perfect!
Also, nice use of the LifecycleHook! I didn't even know you could use it with the old ProxyListeners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
v2provider became available as opt-in.v1provider was deprecated and we encouraged users to opt-in to our new S3v2provider.v2became the default implementation Switch to new Lambda provider implementation #6724.v1provider (this PR) and the new native S3 providerv3becomes available make new s3 v3 provider default #8785.v3becomes the default.v2provider will be deprecatedv2will be removed completely.Changes
Add a log warning when the legacy S3 v1 provider is used. Only logged during initialization (
on_after_init) for people using the legacy S3 service.Discussion
Consistency: Trying to align the language for the deprecations and removals of s3, lambda, stepfunctions /cc