fix s3 v3 ListObjectsV2 and ListObjectVersions pagination #9430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
3b34d37 to
a13acf1
Compare
macnev2013
approved these changes
Oct 23, 2023
a13acf1 to
3abae13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As reported in #9427 (comment)
After validating against AWS and writing some more tests which we didn't cover, we were not sorting keys properly (not leaving at the right moment in the loop).
This is based on #9429 as both are modifying the behaviour and I didn't want the merge conflict.
Changes
Fixed the behaviour to properly match AWS and wrote a good amount of tests to validate this. Took the opportunity to validate and introduce the behaviour for
ListObjectVersionspagination, which is not done in moto yet but is work in progress.