fix s3 v3 preconditions #9448
Merged
fix s3 v3 preconditions #9448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Using the
object_storerust crate test suite, I've spotted an issue in our handling of preconditions for v3.Basically, the
LastModifiedfield on the S3 object is stored with millisecond precision for internal use like sorting when callingListObjects*.But when comparing against
ModifiedSince/UnmodifiedSincepreconditions headers, those are sent using second precision, and we need to check for strict equality/superiority/inferiority. So something like the following should not be true if the precision is second:last_modified=datetime.datetime(2023, 10, 23, 16, 19, 41, 798495, tzinfo=zoneinfo.ZoneInfo(key='GMT')) > if_unmodified_since=datetime.datetime(2023, 10, 23, 16, 19, 41, tzinfo=datetime.timezone.utc)Changes
Adapted the check by rounding last modified before comparison, and created 2 AWS tests.