harden s3 v3 concurrency #9517
Merged
harden s3 v3 concurrency #9517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Following a failure when trying to set the v3 provider as default, I had this PR shelved since a while as I was expecting it to happen.
https://app.circleci.com/pipelines/github/localstack/localstack/19625/workflows/c064060a-3962-4b34-96a0-6c0bfe0efc00/jobs/153568/tests
This PR hardens S3 v3 concurrency, by shallow copying
dictthat will be accessed concurrently before calling.values,.keysor.itemson them, which could trigger exception as they would be modified during iteration.\cc @dfangl since we worked on this together for the v2 provider
Changes
Shallow-copy some dictionaries so that they wouldn't be modified during iteration from concurrent requests.
Also added a test to check for iteration during
List*calls.