Remove edge port config #9636
Merged
Remove edge port config #9636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92e2e2f to
086b121
Compare
Merged
alexrashed
approved these changes
Nov 15, 2023
This is correct 👍 I wanted to be transparent and labelled it as minor considering that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #9633
Motivation
We initially discussed about keeping internal read-access of
EDGE_PORTas an alias forGATEWAY_LISTEN[0].port. Partly because it was used all over the place. However, after finally removing its usages in #9633, @simonrw suggested removingEDGE_PORTaltogether with 3.0. KeepingEDGE_PORTwould risk legacy usages leading to several networking consistency issues, especially when returning URLs manually.Changes
config.EDGE_PORTand all remaining (test) usages.Read-access to the provided environment variable
EDGE_PORTin compute services such as Lambda, EMR, Batch, ECS, etc will remain supported in LocalStack 3.0. Our networking migration guide introduces the deprecation path.TODO
What's left to do:
Impact Analysis
I didn't find any usages in the public extensions:
These extensions use other helper utils that we deprecated, hence providing a deprecation path.
I skimmed over several code searches using
gh search(2023-11-15):gh search code "EDGE_PORT"(124 results but valid occurrences and other Lambda read-only access will remain supported; I will migrate the remaining samples this week)gh search code "import EDGE_PORT" --language python(5 usages, mostly localstack forks)gh search code "config.EDGE_PORT" --language python --limit 1000(105 usages; skimmed over, mostly from not yet merged localstack or forks)Discussion
❓ Do you know any other implicit usages of
config.EDGE_PORT?