Support Java21 in Lambda #9685
Support Java21 in Lambda #9685
Conversation
Java 21 was released in September, and today amazon added support for it.
There was a problem hiding this comment.
Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Hi @eddumelendez and thank you very much for this initiative 👏👏👏. Some comments:
Therefore, we decided to improve the organization of runtimes to allow easier and faster updates in the future. We have prepared this PR #9697 I hope this is ok for you @eddumelendez. I can add you as a co-author once I merge the PR for proper credits 🥇 . We are looking forward to supporting new runtimes much faster in the future 🚀 |
There was a problem hiding this comment.
Thank you very much @eddumelendez for this initiative 👏👏👏
The SnapStart is a nice catch 👍
As mentioned in the previous comment, we re-organized the runtime. I added some comments to highlight some of the changes. Feel free to checkout the full changelog in our PR adding all the new runtimes at once here: #9697
| } | ||
| SNAP_START_SUPPORTED_RUNTIMES = [Runtime.java11, Runtime.java17] | ||
| SNAP_START_SUPPORTED_RUNTIMES = [Runtime.java11, Runtime.java17, Runtime.java21] |
There was a problem hiding this comment.
great catch 👍 that reminded me about SnapStart when re-organizing the Lambda runtimes.
| @@ -5046,7 +5046,7 @@ def test_layer_policy_lifecycle( | |||
|
|
|||
| class TestLambdaSnapStart: | |||
| @markers.aws.validated | |||
| @pytest.mark.parametrize("runtime", [Runtime.java11, Runtime.java17]) | |||
| @pytest.mark.parametrize("runtime", [Runtime.java11, Runtime.java17, Runtime.java21]) | |||
There was a problem hiding this comment.
glad you noticed this 👍
I consolidated this in the runtimes re-work for easier maintainability
| @@ -12521,6 +12521,150 @@ | |||
| } | |||
| } | |||
| }, | |||
| "tests/aws/services/lambda_/test_lambda_api.py::TestLambdaSnapStart::test_snapstart_lifecycle[java21]": { | |||
| "recorded-date": "02-05-2023, 18:15:11", | |||
There was a problem hiding this comment.
Snapshots always need to be generated automatically as explained under Parity Testing. They must never be edited manually. Hence, the date from spring cannot be correct here.
This great blog post is the best introduction: https://blog.localstack.cloud/2022-08-04-parity-explained/
| @@ -233,6 +233,7 @@ class Runtime(str): | |||
| python3_11 = "python3.11" | |||
| nodejs20_x = "nodejs20.x" | |||
| provided_al2023 = "provided.al2023" | |||
| java21 = "java21" | |||
There was a problem hiding this comment.
This should be auto-generated through AWS Server Framework (ASF)
|
The latest image is already out and the next tagged patch release will be published very soon (ETA: tomorrow). @eddumelendez Congratulations on your first LocalStack contribution 🥳 |
Motivation
Java 21 was released in September, and today amazon added support
for it.
Changes
Add
java21as a runtime.