Conversation
dkotter
requested changes
Apr 9, 2025
Co-authored-by: Darin Kotter <[email protected]>
dkotter
approved these changes
Apr 10, 2025
qasumitbagthariya
approved these changes
Apr 30, 2025
Collaborator
There was a problem hiding this comment.
QA Update ✅
I have verified this PR in the fix/92 branch, which has been fixed and is functioning as intended.
I tested the following on this branch:
- Note is shown under the "List Options" section of the settings.
Testing Environment
Details
- WordPress: 6.8
- Theme: Twenty Twenty-Four 1.3
- PHP: 8.0.30
- Web Server: Nginx 1.20.2
- Browser: Chrome
- OS: macOS 15.2
- Branch: smoke-testing
Steps to Test- As mentioned in the PR description.
Test Results - It is working as expected.
Functional Demo / Screencast -
Special Notes - Ready for UAT
Testing Document status:
Cases related to this Issue/PR are added to the Critical Flow Wiki pages:
- Yes - pending
- Not Required/Applicable for this PR
Noted: I tried adding the website URL, but it threw an error from Mailchimp's side. However, the PR notice looks good overall.
Collaborator
Regression / Smoke Test Report ✅Tested with the Testing Environment Details
Next Step- Ready to Merge 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
As reported in #91 and #92, the "« return to our website" button could lead to a 404 error from the subscribe/unsubscribe confirmation page if the website URL is not set in the Mailchimp Audience settings.
This PR adds a note under the "List Options" section, instructing users to set the website URL in the Mailchimp Audience settings to prevent 404 errors and ensure users can return to the website without any issues.
Closes #91
Closes #92
How to test the Change
Changelog Entry
Credits
Props @MaxwellGarceau @dkotter @iamdharmesh
Checklist: