Feature/fix project delete issue #657
Conversation
- Add MAPSWIPE_ENVIRONMENT as prod in docker-compose.yml
ebdf351 to
05ae18c
Compare
laurentS
left a comment
There was a problem hiding this comment.
Looks ok to me. I'm baffled by the fact that django doesn't support on delete constraints!
| SENTRY_DSN: ${DJANGO_SENTRY_DSN} | ||
| SENTRY_SAMPLE_RATE: ${DJANGO_SENTRY_SAMPLE_RATE:-0.2} | ||
| MAPSWIPE_ENVIRONMENT: ${MAPSWIPE_ENVIRONMENT:-dev} | ||
| MAPSWIPE_ENVIRONMENT: ${MAPSWIPE_ENVIRONMENT:-prod} |
There was a problem hiding this comment.
Why the change to prod here? I would have thought that keeping things to dev by default would make it easier to start a dev env for newcomers, and also avoid any accidental actions on prod for users who happen to have prod info available.
There was a problem hiding this comment.
Currently docker-compose.yaml is not development friendly as we need to build for each change and also the nginx configs require some custom work. That is why we created docker-compose.tc.yaml to fit our development need which is also WIP.
So, as we are using docker-compose.yaml in the production run, I used the environment to be prod by default. We should define this accordingly in staging/production. But also we are using separate sentry projects in staging/production, this is not really used.
There was a problem hiding this comment.
I'm baffled by the fact that django doesn't support on delete constraints!
Same here.
Address