Use a different geojson validator #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozenhelium
approved these changes
Mar 7, 2023
frozenhelium
approved these changes
Mar 7, 2023
Member
|
if this is ready to be merged please change from draft. thank you. |
Contributor
|
@tnagorra Should we merge this? |
Member
|
would also be useful if you could note the reason for the change in geojson validator - i.e. which issue(s) is this solving? |
Contributor
Author
|
The conversation is on slack at https://mapswipe.slack.com/archives/C0HCW2CJJ/p1677643592304189?thread_ts=1677518532.043429&cid=C0HCW2CJJ I have also updated the description of the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently using
@turf/boolean-validfor validation of geojson.We have a false negative for a geojson. (For more information https://mapswipe.slack.com/archives/C0HCW2CJJ/p1677586146742749?thread_ts=1677518532.043429&cid=C0HCW2CJJ)
The library does not specify what is wrong with the geojson which is not very useful.
Changing the geojson validation library from
@turf/boolean-validto@placemarkio/check-geojsonso that we get better errors and avoid issue with the false negative.