-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Serious problems on the axes documentation #6055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Pull requests for documentation are always welcome! |
OK, I'll see if I have time to make a PR in the next weekend. So is my understanding above on the |
|
Yes, this is what I mean, and I think this distinction can also be seen in the code? Like, |
Yup, we do make that distinction in the code 🐑 . Thanks for pointing that out! |
@tacaswell I would like to work on this. So, if I understand correctly I am supposed to make changes in docstrings set_xlim() and set_ylim() such that Is that it? |
Note quite. For 1.: There is a distinction between data limits and view limits. The data limits are the bounding box of all the data in the axes, but usually the axes leave some margin around the data, so
For 2. This is about the fact that
or similar. |
* DOC:Update axes documentation Add info about the fact no change in view limits with `autoscale_view()` if axes already set, e.g with `set_xlim()` closes #6055 * fix formatting issues * update note set_xlim ---> `set_xlim`
I've found two problems in the documentation of
axes
:set_xlim()
andset_ylim()
, it read: "Set the data limits for the xaxis". It should be view limits instead, which is very confusing.autoscale_view()
, it should be mentioned that, ifset_xlim()
orset_ylim()
has been called on the same axes before,autoscale_view()
will not work (because_autoscaleXon
would have been set to False by the above two functions) andautoscale()
should be used instead.The text was updated successfully, but these errors were encountered: