Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC:Update axes documentation #14989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 9, 2019
Merged

DOC:Update axes documentation #14989

merged 3 commits into from
Aug 9, 2019

Conversation

sameshl
Copy link
Contributor

@sameshl sameshl commented Aug 6, 2019

Add info about the fact no change in view limits with autoscale_view() if axes already
set, e.g with set_xlim()

closes #6055

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Add info about the fact no change in view limits with `autoscale_view()` if axes already
set, e.g with `set_xlim()`

closes #6055
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few code formatting issues that need to be fixed, that are listed here: https://travis-ci.org/matplotlib/matplotlib/jobs/568199606#L2409 - let me know if anything on that list is unclear. Otherwise thanks for the PR!

@sameshl
Copy link
Contributor Author

sameshl commented Aug 8, 2019

@dstansby I think it looks good now

@@ -2362,6 +2362,10 @@ def autoscale_view(self, tight=None, scalex=True, scaley=True):
changed after the artist has been added to an Axes instance. In that
case, use :meth:`matplotlib.axes.Axes.relim` prior to calling
autoscale_view.

If the views of the axes are fixed, e.g. via set_xlim, they will not
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If the views of the axes are fixed, e.g. via set_xlim, they will not
If the views of the axes are fixed, e.g. via `set_xlim`, they will not

set_xlim ---> `set_xlim`
@timhoffm timhoffm dismissed dstansby’s stale review August 9, 2019 05:13

Formatting fixed

@timhoffm timhoffm added this to the v3.2.0 milestone Aug 9, 2019
@timhoffm timhoffm merged commit 3c60590 into matplotlib:master Aug 9, 2019
@timhoffm
Copy link
Member

timhoffm commented Aug 9, 2019

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serious problems on the axes documentation
3 participants