Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Various backend cleanups. #10209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2019
Merged

Various backend cleanups. #10209

merged 1 commit into from
Jan 19, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 10, 2018 •
edited
Loading

Split out from the qt5cairo and wxcairo PRs.

  • GTK3: is_drawable is the same as mapped & visible
    (https://developer.gnome.org/gtk3/stable/GtkWidget.html#gtk-widget-is-drawable)
  • Synchronous draw appears unnecessary on GTK3 based on tests (probably
    was only needed in early animation code).
  • Most of the Wx printout code has been removed in 84ffb60; this PR just
    deprecates some remnants of it. MenuButtonWx is likewise unused since
    the removal of "classic" toolbars in 4243470; this PR deprecates it.
  • _convert_agg_to_wx_image is unused; _WX28_clipped_agg_as_bitmap can
    reasonably be inlined into _convert_agg_to_wx_bitmap.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer force-pushed the backend-cleanups branch 4 times, most recently from eb782f7 to aaa7f1b Compare January 16, 2018 05:21
@anntzer anntzer added this to the v3.0 milestone Feb 15, 2018
@anntzer anntzer force-pushed the backend-cleanups branch 3 times, most recently from 5325b83 to 9261f57 Compare February 15, 2018 21:04
QuLogic
QuLogic reviewed Feb 18, 2018
View reviewed changes
@anntzer anntzer force-pushed the backend-cleanups branch 2 times, most recently from d7f7556 to afe3bd7 Compare February 18, 2018 04:07
@anntzer
Copy link
Contributor Author

anntzer commented Feb 18, 2018

all comments addressed

@QuLogic
Copy link
Member

QuLogic commented Feb 19, 2018

OK, but conflicts.

@anntzer
Copy link
Contributor Author

anntzer commented Feb 19, 2018

rebased

@anntzer anntzer force-pushed the backend-cleanups branch 3 times, most recently from 592b9ec to a9d101e Compare February 26, 2018 21:02
@anntzer anntzer force-pushed the backend-cleanups branch 3 times, most recently from 64d9340 to 0d417b5 Compare April 3, 2018 16:46
@anntzer anntzer force-pushed the backend-cleanups branch from 0d417b5 to 5a10e50 Compare May 7, 2018 06:55
@anntzer anntzer force-pushed the backend-cleanups branch 3 times, most recently from fa0c1be to d73b9d6 Compare July 8, 2018 16:04
@jklymak jklymak modified the milestones: v3.0, v3.1 Jul 9, 2018
@anntzer anntzer force-pushed the backend-cleanups branch 2 times, most recently from f011054 to 4d49e44 Compare July 12, 2018 14:14
@anntzer anntzer force-pushed the backend-cleanups branch 2 times, most recently from a768f8e to 969a924 Compare November 8, 2018 12:52
@anntzer anntzer mentioned this pull request Nov 21, 2018
Merged
6 tasks
timhoffm
timhoffm approved these changes Nov 22, 2018
View reviewed changes
@anntzer
Various backend cleanups.
03a663d 
Split out from the qt5cairo and wxcairo PRs.

- GTK3: is_drawable is the same as mapped & visible
  (https://developer.gnome.org/gtk3/stable/GtkWidget.html#gtk-widget-is-drawable)
- Synchronous draw appears unnecessary on GTK3 based on tests (probably
  was only needed in early animation code).
- Most of the Wx printout code has been removed in 84ffb60; this PR just
  deprecates some remnants of it.  MenuButtonWx is likewise unused since
  the removal of "classic" toolbars in 4243470; this PR deprecates it.
- Don't initialize the wx statusbar to "None" (which just looks strange)
  -- other backends just start with an empty status text.
- _convert_agg_to_wx_image is unused; _WX28_clipped_agg_as_bitmap can
  reasonably be inlined into _convert_agg_to_wx_bitmap.
- Remove some unused private tk apis.
- Simplify toolkit mocking in the docs.  In particular pycairo is
  Py3-compatible only since 1.11.0 so the version_check is unneeded.
- Removed the old list of deprecations (18-02-15) that has already been
  integrated into the 3.0 release notes in favor of a new list (for
  3.1).
@anntzer
Copy link
Contributor Author

anntzer commented Jan 17, 2019

@QuLogic thanks for the review, rebased (and fstringified two places in backend_wx that were already being cleaned up).

@QuLogic QuLogic closed this Jan 19, 2019
@QuLogic QuLogic reopened this Jan 19, 2019
@timhoffm timhoffm merged commit e9b8d3f into matplotlib:master Jan 19, 2019
@anntzer anntzer deleted the backend-cleanups branch January 19, 2019 10:23
@anntzer anntzer mentioned this pull request Jun 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @QuLogic @timhoffm @jklymak