TST: Don't use set -e. #10217
Merged
TST: Don't use set -e. #10217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may or may not help with Travis.
|
No luck with that, but let's debug a little. |
|
No luck so far; feel free to push any other ideas, but maybe squash before merging if it works. |
|
I think we should temporarily drop |
|
This is passing travis-ci. I suggest we merge this for now until we figure out what gdb is doing. I can modify #10216 so it is a reminder that gdb has been removed.... |
6 tasks
|
Sorry @QuLogic , I hijacked your debug branch to get this working again. |
|
👍 nice team work |
|
Backported to |
This was referenced Jan 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This may or may not help with Travis, if we're lucky.
PR Checklist