Don't use gdb on Travis (as it breaks the build). #10223
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate (plus or minus an 'x') #10217... |
|
... which as we can see, does unbreak the builds. |
|
Oh, sorry, I saw @QuLogic's original PR but missed your changes. |
|
Did we want -ex for 'set'? Its '-v' for #10217 ? |
|
I would keep "set -e" (and thus drop the "return $?"); set -x is nice as it removes the need to echo the pytest args ourselves (it's exactly what -x does...); -x also makes -v a bit redundant. |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Let's see whether this helps unbreaking the build...
PR Checklist