Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bug Fix - Polar plot rectangle patch not transformed correctly (#8521) #10488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

x-meowzilla
Copy link

PR Summary

Fixed rectangle patch not transformed correctly in polar plot #8521.
_interpolation_steps field should be revised to new value in PolarAxes instead of using default value (1).

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell
Copy link
Member

Does this address #9265 and the reasons we reverted the original fix?

@tacaswell tacaswell added this to the v3.0 milestone Feb 16, 2018
@QuLogic
Copy link
Member

QuLogic commented Feb 16, 2018

This is effectively the same as #8539 (which was reverted), though perhaps a bit better, but it still breaks the radar axes example.

@QuLogic
Copy link
Member

QuLogic commented Feb 16, 2018

With the slightly cleaner implementation, maybe the radar example could override add_patch to not do interpolation.

@x-meowzilla
Copy link
Author

May I know what's the expected output for radar chart?

@afvincent
Copy link
Contributor

@MeowsterEric See the expected outcome in #9261 :)

@x-meowzilla
Copy link
Author

Thanks. I will take a look.
Btw, how do I properly set up the image comparison test?
Seems like the expected and actual image has RMS diff of 35.0

@x-meowzilla
Copy link
Author

What's the preferred image comparison tolerance value?

@QuLogic
Copy link
Member

QuLogic commented Feb 17, 2018

The preferred image tolerance is 0. Make sure you have build Matplotlib correctly for image comparison tests and then you can copy the result of the test as the expected image.

Please also add style='mpl20' to the image_comparison decorator so you get a new-style image.

@efiring
Copy link
Member

efiring commented Mar 5, 2018

Given that this breaks an example, and that this plus a proposed fix are in #10561, I am closing this as redundant. It is still available and linked, so the comments can be reviewed as part of the history when considering #10561.

@efiring efiring closed this Mar 5, 2018
@x-meowzilla x-meowzilla deleted the bugfix8521 branch March 5, 2018 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants