Revert "Merge pull request #8539 from Tuan333/tuan" #9265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3e2e31e, reversing changes made to 8149536. This has some un-intended consequences (see matplotlib#9261). This exposes a bigger issue about drawing on to non-linear axes which is if we transform only the vertices or the full paths. Which the user wants is dependent on context so we need to expose this at the user API in a nice way, but is a bigger change than we can accommodate for 2.1. Reverting this change to return to the (slightly) broken state which has been the satus-quo 7 years.
dopplershift
approved these changes
Oct 2, 2017
|
Bit confused what this has to do with 8149536? |
|
That is the commit of the master branch the PR was merged into. |
|
Oh, I was reading "to" as "by"... |
QuLogic
approved these changes
Oct 2, 2017
|
This passed appveyor (but failed on a slight decrease in coverage due to removing a test). |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3e2e31e, reversing
changes made to 8149536.
This has some un-intended consequences (see #9261). This exposes a
bigger issue about drawing on to non-linear axes which is if we
transform only the vertices or the full paths. Which the user wants
is dependent on context so we need to expose this at the user API in a
nice way, but is a bigger change than we can accommodate for 2.1.
Reverting this change to return to the (slightly) broken state which
has been the satus-quo 7 years.
This is from discussion with @efiring and @dopplershift on the phone call.
attn @QuLogic