Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Doc: Make first line in tables darker & bullets in tables #11430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ImportanceOfBeingErnest
Copy link
Member

@ImportanceOfBeingErnest ImportanceOfBeingErnest commented Jun 13, 2018

PR Summary

In #11411 @timhoffm made a nice general overhaul of the style sheet for the docs. During that process a little detail got lost. Previously the first and last border line of a table were darker, as to frame the table.
This PR would restore this behaviour.
Left: Current table look, Right: with this PR

image           image

Additionally, I would like to reintroduce the bullets in tables that were removed in that PR

Previously:
image

With this PR:
image

I also gave the "important" admonition the same color as the "warning", instead of it being white

image      image

@jklymak
Copy link
Member

jklymak commented Jun 13, 2018

I’m 👍 on the line thickness. Mildly against the bullets as I don’t think they add clarity or aesthetics.

@ImportanceOfBeingErnest ImportanceOfBeingErnest force-pushed the doc_makefirstlineintablesdarker branch from b356221 to ce39023 Compare June 13, 2018 01:53
@ImportanceOfBeingErnest
Copy link
Member Author

Without the bullets the complete table just looks like a wordcloud to me. I could make them even lighter in grey (#bbb).

@afvincent
Copy link
Contributor

FWIW, I personally prefer the version with bullets: I cannot really explain why, but I find it slightly easier to read.

@jklymak
Copy link
Member

jklymak commented Jun 14, 2018

OK, two against one for the bullets. Good enough for me!

@jklymak jklymak merged commit 9714469 into matplotlib:master Jun 14, 2018
@timhoffm
Copy link
Member

I wouldn’t have added the bullets either, but it’s ok-ish.

👍 for the other changes.

@ImportanceOfBeingErnest ImportanceOfBeingErnest deleted the doc_makefirstlineintablesdarker branch June 15, 2018 00:37
@timhoffm
Copy link
Member

timhoffm commented Jun 16, 2018

The bullet solution does not work well with Firefox.

Firefox 57.0.4: The bullets are quite large and offset to the bottom

grafik

Firefox 60.0.2: Size and position are ok, but the color is ignored.

grafik

@jklymak
Copy link
Member

jklymak commented Jun 16, 2018

Same on Safari...

@tacaswell tacaswell added this to the v2.2-doc milestone Jun 16, 2018
@tacaswell
Copy link
Member

@meeseeksdev backport to v2.2.2-doc

@lumberbot-app
Copy link

lumberbot-app bot commented Jun 16, 2018

There seem to be a conflict, please backport manually

@ImportanceOfBeingErnest
Copy link
Member Author

In Firefox 60.0.2 on windows it looks like

image
as desired.

In the following browsers it looks the same, as desired (all run on windows):

  • Opera 53.0
  • Vivaldi 1.10
  • PaleMoon 27.9.3
  • Safari 5.1.7

In Maxthon 4.4.8 the bullets are indeed larger.
image
... which I still find better than having no bullets at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants