-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Doc: Make first line in tables darker & bullets in tables #11430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: Make first line in tables darker & bullets in tables #11430
Conversation
I’m 👍 on the line thickness. Mildly against the bullets as I don’t think they add clarity or aesthetics. |
b356221
to
ce39023
Compare
Without the bullets the complete table just looks like a wordcloud to me. I could make them even lighter in grey ( |
FWIW, I personally prefer the version with bullets: I cannot really explain why, but I find it slightly easier to read. |
OK, two against one for the bullets. Good enough for me! |
I wouldn’t have added the bullets either, but it’s ok-ish. 👍 for the other changes. |
Same on Safari... |
@meeseeksdev backport to v2.2.2-doc |
There seem to be a conflict, please backport manually |
PR Summary
In #11411 @timhoffm made a nice general overhaul of the style sheet for the docs. During that process a little detail got lost. Previously the first and last border line of a table were darker, as to frame the table.
This PR would restore this behaviour.
Left: Current table look, Right: with this PR
Additionally, I would like to reintroduce the bullets in tables that were removed in that PR
Previously:

With this PR:

I also gave the "important" admonition the same color as the "warning", instead of it being white