Fix the docs build. #12322
Merged
Fix the docs build. #12322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux, $DISPLAY is unset, then we can't run a GUI toolkit anyways, so don't warn about that in `show()`. Delete the Note in the docstring which was redundant with the Parameters entry.
Otherwise, wx.GetApp() returns a truthy value and the backend switching machinery believes that a wx event loop is running, leading to warnings about show() not doing anything with agg.
|
Is it possible to make |
|
We already got rid of qt and gtk docs for the same reason. I'd rather write a proper unified interactive backends doc at some point... |
|
Issue (which I dont' completely understand) noted in #12324: Merging to unbreak the build. |
6 tasks
|
@meeseeksdev backport to v3.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 28, 2018
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 28, 2018
QuLogic
added a commit
that referenced
this pull request
Sep 28, 2018
…322-on-v3.0.0-doc Backport PR #12322 on branch v3.0.0-doc (Fix the docs build.)
QuLogic
added a commit
that referenced
this pull request
Sep 28, 2018
…322-on-v3.0.x Backport PR #12322 on branch v3.0.x (Fix the docs build.)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Don't mock wx in docs build.
Otherwise, wx.GetApp() returns a truthy value and the backend switching
machinery believes that a wx event loop is running, leading to warnings
about show() not doing anything with agg.
Builds on top of #12267. Will self-merge if passes.
PR Checklist