-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Building docs has issues with ipython version 7.0.0. Created a condition in the docs-requirements.txt to not allow installing the specific version. #12583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What issues exactly? |
This was the error that I encountered while issuing the command "make html" |
That's only the end of the message; please post the entire thing. |
This was the log file that was created |
This has been fixed on master already I think |
@jklymak on our master or ipython master? |
0dee93a
to
a818630
Compare
@Anirudhsekar96 No, we need to see the warning that it's talking about before the traceback, not the log of the traceback. |
You get that error running our docs on older prs that haven’t been rebased. |
Is this the one? |
Yes, that's the one; it should have been fixed by #12322. Did you try with the latest |
Yes, I forked it today from the main master branch. |
@QuLogic I just cloned and checked it a few minutes ago on my mac and I got the same error. I have to downgrade to |
The issue shows up when trying to build the docs from the master branch against a 3.0.0 installation. I don't see how the changes in #12322 would affect this... |
That's a change in IPython, you will be able to opt-out with IPython 7.1 with |
If the issue has been rectified in IPython 7.1, then wouldn't it be better if we add a condition which skips just the problematic IPython 7.0.0 and 7.0.1 (the condition which I have added in my pull request)? |
You can, but the IPython directive will still be stricter in 7.1 than in 6.x, so you either need to set |
If this was an intentional change to IPython, lets try and fix the offending codeblock |
Closed by #12684, AFAICT. |
I have included a condition to not install ipython version 7.0.0 in the docs-requirement.txt file. This is because Ipython version 7.0.0 wasn't allowing the make html command to build the doc files.