Fix test_non_gui_warning for Azure (and mplcairo). #12726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If on Linux and $DISPLAY is not set, then the non-gui warning is not emitted. We didn't notice that on Travis as $DISPLAY was indeed always set; but it's not on Azure.
timhoffm
approved these changes
Nov 3, 2018
|
Thanks @anntzer ! |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 4, 2018
timhoffm
pushed a commit
that referenced
this pull request
Nov 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If on Linux and $DISPLAY is not set, then the non-gui warning is not
emitted.
We didn't notice that on Travis as $DISPLAY was indeed always set; but
it's not on Azure.
Milestoned as 3.0.x as it goes together with #12267, which was merged as part of #12322.
PR Summary
PR Checklist