Update windows build instructions #13001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
commented
Dec 16, 2018
| :: | ||
|
|
||
| # create a new environment with the required packages | ||
| conda create -n "matplotlib_build" python=3.7 numpy python-dateutil pyparsing pytz tornado cycler tk libpng zlib freetype |
There was a problem hiding this comment.
The pytz dependency has been removed in #11360 and shouldn't be here.
timhoffm
commented
Dec 16, 2018
| The `build_alllocal.cmd` script in the root folder automates these steps if | ||
| you have already created and activated the conda environment. | ||
| conda create -n "matplotlib_build" python=3.7 numpy python-dateutil pyparsing tornado cycler tk libpng zlib freetype msinttypes | ||
| conda activate matplotlib_build |
There was a problem hiding this comment.
New way of activating an environment is conda activate
timhoffm
commented
Dec 16, 2018
| # you have created the environment with conda-forge already activated...) | ||
| conda install pyqt | ||
| # this package is only available in the conda-forge channel | ||
| conda install -c conda-forge msinttypes |
There was a problem hiding this comment.
msinttypes is now available via conda
anntzer
approved these changes
Dec 17, 2018
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
timhoffm
pushed a commit
to timhoffm/matplotlib
that referenced
this pull request
Dec 17, 2018
jklymak
added a commit
that referenced
this pull request
Dec 21, 2018
…v3.0.x Backport PR #13001: Update windows build instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #13000.