-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Update windows build instructions #13001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
anntzer
merged 1 commit into
matplotlib:master
from
timhoffm:update-win-build-instructions
Dec 17, 2018
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -262,8 +262,8 @@ at `matplotlib-winbuild <https://github.com/jbmohler/matplotlib-winbuild>`_. | |
There are a few possibilities to build Matplotlib on Windows: | ||
|
||
* Wheels via `matplotlib-winbuild <https://github.com/jbmohler/matplotlib-winbuild>`_ | ||
* Wheels by using conda packages | ||
* Conda packages | ||
* Wheels by using conda packages (see below) | ||
* Conda packages (see below) | ||
|
||
Wheel builds using conda packages | ||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
@@ -272,32 +272,19 @@ This is a wheel build, but we use conda packages to get all the requirements. | |
The binary requirements (png, FreeType,...) are statically linked and therefore | ||
not needed during the wheel install. | ||
|
||
Set up the conda environment. Note, if you want a qt backend, add ``pyqt`` to | ||
the list of conda packages. | ||
|
||
:: | ||
|
||
# create a new environment with the required packages | ||
conda create -n "matplotlib_build" python=3.7 numpy python-dateutil pyparsing pytz tornado cycler tk libpng zlib freetype | ||
activate matplotlib_build | ||
# if you want a qt backend, you also have to install pyqt (be aware that pyqt doesn't mix well if | ||
# you have created the environment with conda-forge already activated...) | ||
conda install pyqt | ||
# this package is only available in the conda-forge channel | ||
conda install -c conda-forge msinttypes | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. msinttypes is now available via conda |
||
|
||
# copy the libs which have "wrong" names | ||
set LIBRARY_LIB=%CONDA_PREFIX%\Library\lib | ||
mkdir lib || cmd /c "exit /b 0" | ||
copy %LIBRARY_LIB%\zlibstatic.lib lib\z.lib | ||
copy %LIBRARY_LIB%\libpng_static.lib lib\png.lib | ||
|
||
# Make the header files and the rest of the static libs available during the build | ||
# CONDA_DEFAULT_ENV is a env variable which is set to the currently active environment path | ||
set MPLBASEDIRLIST=%CONDA_PREFIX%\Library\;. | ||
|
||
# build the wheel | ||
python setup.py bdist_wheel | ||
|
||
The `build_alllocal.cmd` script in the root folder automates these steps if | ||
you have already created and activated the conda environment. | ||
conda create -n "matplotlib_build" python=3.7 numpy python-dateutil pyparsing tornado cycler tk libpng zlib freetype msinttypes | ||
conda activate matplotlib_build | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. New way of activating an environment is |
||
|
||
For building, call the script ``build_alllocal.cmd`` in the root folder of the | ||
repository:: | ||
|
||
build_alllocal.cmd | ||
|
||
|
||
Conda packages | ||
^^^^^^^^^^^^^^ | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pytz dependency has been removed in #11360 and shouldn't be here.