Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecate NavigationToolbar2QT.adj_window (unused and always None). #13712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2019
Merged

Deprecate NavigationToolbar2QT.adj_window (unused and always None). #13712

merged 1 commit into from
Mar 25, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 19, 2019

All's in the changelog.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@timhoffm timhoffm added this to the v3.2.0 milestone Mar 23, 2019
@timhoffm
Copy link
Member

Moving to 3.1 get the deprecation period running. Feel free to re-milestone if this is not merged when 3.1 will be released.

@timhoffm timhoffm modified the milestones: v3.2.0, v3.1.0 Mar 23, 2019
@tacaswell
Copy link
Member

@anntzer took the liberty of rebase and force-pushing this.

You deprecated too many things and git got confused (overlap with def buttons).

@jklymak jklymak merged commit e974bf0 into matplotlib:master Mar 25, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 25, 2019
@jklymak
Backport PR matplotlib#13712: Deprecate NavigationToolbar2QT.adj_wind…
ca14012 
…ow (unused and always None).
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 25, 2019
Merged
@anntzer anntzer deleted the adjwindow branch March 25, 2019 08:58
jklymak added a commit that referenced this pull request Mar 25, 2019
@jklymak
Merge pull request #13754 from meeseeksmachine/auto-backport-of-pr-13…
382a5b9 
…712-on-v3.1.x

Backport PR #13712 on branch v3.1.x (Deprecate NavigationToolbar2QT.adj_window (unused and always None).)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
GUI: Qt
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @timhoffm @tacaswell @jklymak