Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FIX: adjust suptitle placement after calling constrained_layout #14185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2019
Merged

FIX: adjust suptitle placement after calling constrained_layout #14185

merged 1 commit into from
May 17, 2019

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented May 10, 2019

PR Summary

Constrained layout makes room for a subtitle, but it did not previously move the subtitle into the box that was reserved for it. This PR does that...

closes #13672

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

timhoffm
timhoffm reviewed May 11, 2019
View reviewed changes
@tacaswell tacaswell modified the milestones: v3.2.0, v3.1.1 May 11, 2019
@jklymak jklymak force-pushed the fix-suptitle-placement-CL branch from 9755d8a to 5ca5d6c Compare May 12, 2019 00:20
timhoffm
timhoffm reviewed May 12, 2019
View reviewed changes
pharshalp
pharshalp suggested changes May 14, 2019
View reviewed changes
Copy link
Contributor

@pharshalp pharshalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the change in test_colorbar_location.png intended to be a part of this PR? Looks like it might be an extraneous change.

dstansby
dstansby reviewed May 16, 2019
View reviewed changes
@jklymak jklymak force-pushed the fix-suptitle-placement-CL branch from 3eb5e91 to 4f7b8b0 Compare May 16, 2019 14:29
@dstansby
Copy link
Member

I think test_colorbar_location.png has changed because it has an empty suptitle.

@dstansby dstansby merged commit d062859 into matplotlib:master May 17, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request May 17, 2019
@dstansby
Backport PR matplotlib#14185: FIX: adjust suptitle placement after ca…
d665d03 
…lling constrained_layout
@meeseeksmachine meeseeksmachine mentioned this pull request May 17, 2019
Merged
dstansby added a commit that referenced this pull request May 17, 2019
@dstansby
Merge pull request #14234 from meeseeksmachine/auto-backport-of-pr-14…
fdc92c7 
…185-on-v3.1.x

Backport PR #14185 on branch v3.1.x (FIX: adjust suptitle placement after calling constrained_layout)
@QuLogic QuLogic modified the milestones: v3.1.1, v3.1-doc, v3.1.0 May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pharshalp pharshalp pharshalp requested changes

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

fig.suptitle overlapping with axis using constrained_layout
6 participants
@jklymak @dstansby @timhoffm @pharshalp @tacaswell @QuLogic