ENH: Add argument size validation to quiver. #14424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Jun 3, 2019
| @@ -72,12 +72,16 @@ | |||
| U, V : 1D or 2D array-like | |||
| The x and y direction components of the arrow vectors. | |||
|
|
|||
| They must have the same number of elements, matching the number of arrow | |||
| locations. They may be masked. | |||
There was a problem hiding this comment.
With the same mask or is different allowed?
There was a problem hiding this comment.
They can be different. The masks are combined so that a masked point in any of U, V, or C is the same as if all were masked.
There was a problem hiding this comment.
Maybe more precisely
Elements that are masked in U or V are not drawn.
instead of just just
They may be masked.
There was a problem hiding this comment.
Suggested change
| locations. They may be masked. | |
| locations. *U* and *V* may be masked. Only locations unmasked in *U*, *V*, and *C* will be drawn. |
There was a problem hiding this comment.
I think commiting this suggested change will cause problems due to the line being too long for flake?
tacaswell
approved these changes
Aug 27, 2019
ImportanceOfBeingErnest
approved these changes
Aug 29, 2019
ImportanceOfBeingErnest
added a commit
that referenced
this pull request
Aug 30, 2019
6 tasks
jklymak
added a commit
that referenced
this pull request
Aug 30, 2019
Follow up on #14424 for docstring
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14060.
PR Summary
PR Checklist