-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
3.2.0 API changes page #15163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.2.0 API changes page #15163
Conversation
I'm not 100% confident this is complete. E.g. in #11387 a file |
Good catch on that! I am almost afraid to ask how you noticed that, see #11387 (comment) for what I think is going on here. I think we should bump the warning to v3.2 in the code and duplicate the deprecation text in the 3.2 API changes, but not worry about removing it from the 3.1 docs |
I now did duplicate the deprecation text in the 3.2 API changes. I did not touch source code here. There is another "conflict" for api/api_changes/2019-02-11-PGE.rst from https://github.com/matplotlib/matplotlib/pull/13986/files. That's a change to an entry that initially into 3.1, but the change did not get backported. I think this change is anyways rather a "what's new" (now more things are supported), so we could mention it in the what's new of 3.2 instead. |
Thanks for picking this up! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few typos and comments (if it helps).
|
||
Reduced default value of :rc:`axes.formatter.limits` | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the titles do not have that extra line: is there a reason that it was kept here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't fix this, as we do not have a rule about that and it is done inconsistently in our documentation. If we are to establish a rule, it should be done in such a manner that everyone is aware.
|
||
Autoscaling | ||
~~~~~~~~~~~ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above: most of the titles do not have that extra line.
|
||
- if the streamplot goes all the way to the edges of the vector field, then the | ||
axis limits are set to match exactly the vector field limits (whereas they | ||
would be sometimes be off by a small floating point error previously). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One extra “be” occurrence to remove in “… they
would be sometimes be off by…?”
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
would be sometimes be off by a small floating point error previously). | ||
- if the streamplot does not reach the edges of the vector field (e.g., due to | ||
the use of ``start_points`` and ``maxlength``), then margins expansion will | ||
not cross the the vector field limits anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“… the the vector field…”
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
the use of ``start_points`` and ``maxlength``), then margins expansion will | ||
not cross the the vector field limits anymore. | ||
|
||
This change is also used internally to ensure that polar plots don't display |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that some purists might argue for replacing “don't” with “do not”.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't fix this. I don't think it matters much.
|
||
To always get the anti-aliasing behavior, no matter what the up/down sample | ||
rate, set :rc:`interpolation` to "hanning" (or one of the other filters | ||
available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a closing parenthesis: “… one of the other filters available*)*.”
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
`~matplotlib.axes.Axes.axis()` is deprecated (such arguments used to be | ||
silently ignored). | ||
|
||
``minor`` argument will be become keyword-only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title phrasing sounds a bit weird (at least to my non-native ears…): “… will be become…?”
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(That's definitely not proper english)
|
||
DLLs copied in the source tree are now always packaged; the | ||
``package_data.dlls`` entry has no effect anymore. If you do not want to | ||
include the DLLs, don't copy them into the source tree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW same comment as before about “don't” vs. “do not”.
PR Summary
New version of the 3.2.0 API changes page. This was started by @dstansby in #15141. Here, the remaining API changes are incorporated.
PR Checklist