Thanks to visit codestin.com
Credit goes to github.com

Skip to content

3.2.0 API changes page #15141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

dstansby
Copy link
Member

Here's the PR to put everything together for the API changes for 3.2.0. I'll probably work on this in chunks, and ping everyone when it's ready for review.

@dstansby dstansby added this to the v3.2.0 milestone Aug 27, 2019
@dstansby dstansby force-pushed the 320-apichanges branch 3 times, most recently from 6343e47 to 27fa5db Compare August 28, 2019 14:45
@dstansby dstansby added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Aug 28, 2019
@dstansby dstansby force-pushed the 320-apichanges branch 2 times, most recently from 35b4978 to 13c7de5 Compare August 28, 2019 16:47
@dstansby dstansby changed the title Start 3.2.0 API changes page 3.2.0 API changes page Aug 30, 2019
@dstansby
Copy link
Member Author

@matplotlib/developers I'm burnt out on finishing this up (there's not much left), so would be grateful if someone else can take this over (feel free to force push to my branch or take a copy and open a new PR).

Both this and the 3.1.0 API changes have been a real drain of time, so I'm going to propose a change in how this works for 3.3.0 soon.

@ImportanceOfBeingErnest
Copy link
Member

I've done the remaining API changes. Unfortunately, I could not push after rebasing (technically, because "Updates were rejected because the tip of your current branch is behind its remote counterpart.", realistically, because I still haven't understood how git works)

Therefore I made #15163 out of it.

@NelleV
Copy link
Member

NelleV commented Aug 31, 2019

Rebasing changes the history, and thus the local git hashes. You probably rebased something that was already on @dstansby's branch. As a result, git thinks you need to pull the more recent history before pushing (hence your tip being behind the remote's counterpart).

@tacaswell
Copy link
Member

Both this and the 3.1.0 API changes have been a real drain of time, so I'm going to propose a change in how this works for 3.3.0 soon.

I am very grateful for your work on this!

@tacaswell
Copy link
Member

@ImportanceOfBeingErnest If you had don git push --force ... it would have worked, but closing this PR in favor of #15163

@tacaswell tacaswell closed this Sep 1, 2019
@tacaswell tacaswell modified the milestones: v3.2.0, unassigned Sep 1, 2019
@dstansby dstansby deleted the 320-apichanges branch September 2, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. status: work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants