Warn if a temporary config/cache dir must be created. #15933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Dec 15, 2019
timhoffm
reviewed
Dec 15, 2019
a19d9c5 to
5837012
Compare
dstansby
previously requested changes
Dec 17, 2019
5837012 to
9d2d096
Compare
|
Ah, good catch re: testability, didn't think of that possibility, done. |
9d2d096 to
095a60c
Compare
a23d4be to
0cb2ae1
Compare
|
looks like chmod() doesn't work that easily on Windows (https://docs.python.org/3/library/os.html#os.chmod); possibly fixable but I'm going to claim that a non-writable home directory is sufficiently uncommon on Windows that we can skip the test there (and in any case the actual functionality should still work there). |
efiring
approved these changes
Jan 17, 2020
|
@dstansby good to go? |
Paying the cost of regen'ing the font cache on every import seems a bit silly when one can just set MPLCONFIGDIR to a persistent directory. Moreover the tmpdir approach is brittle against forking; this is fixable but somewhat complex to do.
|
rebased |
0cb2ae1 to
694d69e
Compare
6 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paying the cost of regen'ing the font cache on every import seems a bit
silly when one can just set MPLCONFIGDIR to a persistent directory.
Moreover the tmpdir approach is brittle against forking; this is fixable
but somewhat complex to do.
Closes #15911, see also #832 (see discussions in both of them).
Edit: also closes #16677.
PR Summary
PR Checklist