Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Dedupe implementations of fill_between & fill_betweenx. #16023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2020
Merged

Dedupe implementations of fill_between & fill_betweenx. #16023

merged 1 commit into from
Mar 10, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 25, 2019

PR Summary

Redo of #9238.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer mentioned this pull request Mar 9, 2020
Closed
6 tasks
jklymak
jklymak approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should go in. Its a bit hard to follow, but will stop inconsistencies from popping up in fill_between/x.

@tacaswell tacaswell added this to the v3.3.0 milestone Mar 10, 2020
@tacaswell tacaswell merged commit c0fca72 into matplotlib:master Mar 10, 2020
@anntzer anntzer deleted the fill_between branch March 10, 2020 19:55
@anntzer anntzer mentioned this pull request Mar 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @tacaswell