Fill between cleanup #9238
Closed
Fill between cleanup #9238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the calls to interp passes data which is not guaranteed to be in increasing order, which interp requires. Just use argsort the data, like is done above.
fill_between and fill_betweenx were almost entirely duplicated between each other. This adds a helper function with the common functionality, and attempts to generalize between them without making the logic *too* convoluted.
|
|
|
Ok...doing this off of un-patched master would result in conflicts. |
|
|
|
I don't think we need this. |
|
Actually, this still has the work to refactor and reduce duplication. I’ll rebase so it’s clear what’s new here. |
|
Sorry |
|
This looks like a nice refactor and I don't want to see it get lost, but unfortunately it needs a non-trivial rebase. Perhaps we can push on it right after the 2.2 release? |
|
I should be able to manage that after 2.2. |
6 tasks
|
Superseded by #16023. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks #9236 from v2.1.x. It also goes further and refactors
fill_between(x)a bit.fill_betweenandfill_betweenxwere almost entirely duplicated between each other. This adds a helper function with the common functionality, and attempts to generalize between them without making the logic too convoluted.