Fix fill_between with decreasing data #9236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On master I think I'm going to refactor the fill_betweens...there's too much duplicated code between them. |
84aa0ec to
09d3dcc
Compare
WeatherGod
approved these changes
Sep 26, 2017
|
don't forget to mark the svg file as binary. Also, as a side note: there is an outstanding bug (not filed) where one of the fill functions respects cyclers properly, but the others don't. I came across it during my prep for my tutorial, but never got around to fixing it. |
|
The SVG binary stuff was a wildcard, so I don't need to do anything, but it's only on master. I'll keep an eye out for the cycler stuff when I work on refactoring them. |
One of the calls to interp passes data which is not guaranteed to be in increasing order, which interp requires. Just use argsort the data, like is done above.
09d3dcc to
61f4fa3
Compare
|
Rebased on current v2.1.x branch and fixed up test to make sure it uses mpl20 style. |
NelleV
approved these changes
Sep 26, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the calls to interp passes data which is not guaranteed to be in
increasing order, which interp requires. Just use argsort the data, like
is done above.
Fixes #9235.
@tacaswell This fixes a bug in a new feature for 2.1--I'd love to see this go in before you cut if possible. 😁